Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamable for merkle blob serialization #19154

Merged
merged 8 commits into from
Jan 28, 2025
Merged

streamable for merkle blob serialization #19154

merged 8 commits into from
Jan 28, 2025

Conversation

altendky
Copy link
Contributor

  • streamable for merkle blob serialization
  • wip

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jan 15, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky marked this pull request as ready for review January 27, 2025 16:02
@altendky altendky requested a review from a team as a code owner January 27, 2025 16:02
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 12991887808

Details

  • 147 of 147 (100.0%) changed or added relevant lines in 2 files are covered.
  • 29 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 91.465%
Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 73.24%
chia/_tests/core/data_layer/test_merkle_blob.py 1 99.7%
chia/farmer/farmer.py 1 73.37%
chia/daemon/client.py 1 74.16%
chia/full_node/full_node.py 3 86.26%
chia/full_node/weight_proof.py 4 90.64%
chia/daemon/server.py 7 83.46%
chia/timelord/timelord.py 11 78.52%
Totals Coverage Status
Change from base Build 12961574794: 0.02%
Covered Lines: 105485
Relevant Lines: 115142
💛 - Coveralls

@altendky altendky merged commit 4363032 into long_lived/datalayer_merkle_blob Jan 28, 2025
300 checks passed
@altendky altendky deleted the streamable_for_merkle_blob_serialization branch January 28, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchirica fchirica fchirica approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altendky @fchirica